Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for single-node cluster setups #13

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

PhilipSchmid
Copy link
Collaborator

No description provided.

@PhilipSchmid PhilipSchmid self-assigned this Oct 31, 2023
Signed-off-by: Philip Schmid <philip.schmid@isovalent.com>
@PhilipSchmid PhilipSchmid force-pushed the pr/philip/support_single_nodes_clusters branch from 99a6f7f to a949796 Compare October 31, 2023 08:06
Copy link

@f1ko f1ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Would like to see "enforcement" of the owner and expiry tag in an upcoming commit though (right now the user can decide which tags to put meaning that instances could run forever if they are forgotten about).

@PhilipSchmid
Copy link
Collaborator Author

Thanks!

I get your point regarding tag enforcement. However, as this is a public Terraform module and can also be used by other users/companies, it shouldn't enforce too much as use cases might differ.

@PhilipSchmid PhilipSchmid merged commit f43c194 into main Oct 31, 2023
2 checks passed
@PhilipSchmid PhilipSchmid deleted the pr/philip/support_single_nodes_clusters branch May 6, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants